Skip to content

Add Psu pv override so VGScienta connect works#1926

Merged
oliwenmandiamond merged 2 commits intomainfrom
add_psu_mode_pv
Feb 19, 2026
Merged

Add Psu pv override so VGScienta connect works#1926
oliwenmandiamond merged 2 commits intomainfrom
add_psu_mode_pv

Conversation

@oliwenmandiamond
Copy link
Contributor

Add Psu pv override so connect works, waiting on https://jira.diamond.ac.uk/browse/I09-651 so it standardised.

Instructions to reviewer on how to test:

  1. Check dodal connect for i09 (timesout due to image expected)

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner February 17, 2026 17:10
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (dffe1f8) to head (69f5856).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1926   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         312      312           
  Lines       11749    11750    +1     
=======================================
+ Hits        11638    11639    +1     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond merged commit 004332f into main Feb 19, 2026
10 checks passed
@oliwenmandiamond oliwenmandiamond deleted the add_psu_mode_pv branch February 19, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments